<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Thanks for the patches.<br>
<br>
I have made a few minor changes:<br>
<br>
- I have let the "from log import debug, info, error because" it was
intentional to let them, even if I don't use them, just to avoid to
think about the import when I need one of them. It may change in the
future, but for now it's handy<br>
<br>
- if have not pushed the for _, trigger instead of for
priority,_trigger in src/tools/misc because with this we know what
the first item is for, and the "_" is already used by gettext<br>
<br>
- one of the patches was removing deletionError in
src/memory/sqlite.py. In fact, it was a forgotten addErrback, I have
added it in an other patch.<br>
<br>
Anyway it's now pushed, thanks for your useful help :)<br>
<br>
Cheers<br>
Goffi<br>
<br>
Le 18/01/2013 18:34, Emmanuel Gil Peyrot a écrit :
<blockquote cite="mid:20130118173448.GB2376@yuyuko" type="cite">
<pre wrap="">Hello!
I’ve written a few patches for the core of Salut à Toi that try to fix
its respect of the python coding style as defined in the PEP-0008
document[1]. I also removed every trailing whitespace or semicolon and
made the switch to new-style classes[2].
Those changes are mostly cosmetic, but will certainly make the code
more readable and I hope make the whole project more attirant to the
potential contributors with knowledge of python.
As per a discussion with goffi on the SàT chatroom[3], I didn’t change
the internal method names to follow the PEP-0008 guidelines, that is to
convert them to lowercase_with_underscores (he prefers the mixedCase,
mainly to stay coherend with Twisted), but I still think that would be
much better to do it so I kept the patch to do that change, in the case
of a new issue to that debate.
Among the tools I used for that, I want to thank the very good
pep8ify[4] that made this work much easier, vim, GNU sed, and the GNU
coreutils.
[1] <a class="moz-txt-link-freetext" href="http://www.python.org/dev/peps/pep-0008/">http://www.python.org/dev/peps/pep-0008/</a>
[2] <a class="moz-txt-link-freetext" href="http://stackoverflow.com/questions/54867/old-style-and-new-style-classes-in-python">http://stackoverflow.com/questions/54867/old-style-and-new-style-classes-in-python</a>
[3] <a class="moz-txt-link-abbreviated" href="mailto:xmpp:sat@chat.jabberfr.org?join">xmpp:sat@chat.jabberfr.org?join</a>
[4] <a class="moz-txt-link-freetext" href="http://pep8ify.com/">http://pep8ify.com/</a>
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:dev@goffi.org">dev@goffi.org</a>
<a class="moz-txt-link-freetext" href="http://lists.goffi.org/listinfo/dev">http://lists.goffi.org/listinfo/dev</a>
</pre>
</blockquote>
<br>
</body>
</html>