[dev] [PATCH] unibox as an option (part 1)
Adrien
souliane at mailoo.org
Sam 4 Jan 11:59:21 CET 2014
Hi all,
happy new year, I hope you enjoyed the holidays and family dinners ;)
Thank you Goffi for the last updates, I especially enjoy the better
internationalization system!
I divided my patches into three parts/emails, because last time it was
too much at the same time and a bit confusing.
According to the feedback that we got about the unibox, we decided to
make the unibox optional. This first batch of patch goes to that direction.
When unibox is enabled, I did not systematically disabled the alternate
sending stuff. For example, I think it's OK to be able to reply to a
microblog from the unibox and by clicking a small icon to insert an
editbox directly in the panel, because the icon is not using any extra
space (it doesn't disturb). But the new button "New message" which can
be inserted at the top of a MicroblogPanel will be hidden when unibox is
enabled. Let me know what you think about that (also you can give your
opinion later when libervia.org is running online, it's not a big deal
to do change this kind of thing).
I started to do these changes with a Param added directly in the backend
and defining its key/name in sat_frontends.constants.Const. Later I
implemented a proper way to add frontend's specific parameters (with the
advices of Goffi). With the patches attached to this email, we will get
some errors (JS AttributeError for Const.XXX and "the requested
parameter doesn't exist" in the backend) because I didn't comit the
first dirty way, so it's better to test everything together with the
next batch of patch.
So for the main changes the attached file brings:
- when unibox is disabled, raw text input at the bottom of ChatPanel,
"New message" button at the top of MicroblogPanel
- "comment" icon side the the Microblog main entries et the status can
be edited by clicking it directly.
Regards,
Adrien
-------------- section suivante --------------
Une pièce jointe autre que texte a été nettoyée...
Nom: lib_unibox_option_1.diff
Type: text/x-diff
Taille: 1434 octets
Desc: non disponible
URL: <http://lists.goffi.org/pipermail/dev/attachments/20140104/af07a101/attachment.diff>
Plus d'informations sur la liste de diffusion dev