[SàT dev][en] A bunch of (minor) patches

[Goffi]

Hi,

first of all, thanks for all these contributions.

For all patches I have adapted the commit message to our policy (see 
http://wiki.goffi.org/wiki/Howto_contribute/en ).

Below you can find comments for each patches:

> 0002-Avoid-setting-a-bad-icon.patch allows Wix to start even when
> tray_icon.xpm can't be found (i.e. when sat_media is not installed, as
> discussed in another thread). You may or may not want to apply that upstream,
> my personal opinion is that it can't hurt.

Commited, I have added Olly Betts to contributors in a later commit.

> 0003-Lower-default-setuptools-version.patch, as its name indicates, lowers
> the default version of setuptools from 5.7 to 5.5 in ez_setup.py, which allows
> to build on systems where an older version is available. It works perfectly
> here with Debian's setuptools which is still 5.5.

commited, we should probably do the same for urwid SàText then.


> information_typo.patch fixes a recurring error in the source, namely
> “informations” in a plural form (which is incorrect because “information” is
> uncountable in English).

Oh, that's a gotcha, we'll try to avoid this mistake in the future.

> README4PACKAGERS.patch mainly adds precision about the dependencies. I
> replaced “Urwid-satext >= 0.3.0” with “Urwid-satext 0.4”, since it seems that
> a version of SàT is tied to a given version of Urwid-satext (I know this can
> change, but I think you told us that for now backward compatibility is not
> guaranteed in Urwid-satext). Another notable change is that I removed the
> section about Libervia; since it is packaged independently it didn't make
> sense to have that there IMO, but you may want to keep it nonetheless (after
> all, you probably had a good reason for putting it there in the first place).

This one was a bit modified: first the version of urwid SàText was 
updated meanwhile, but I have changed it to 0.4.1 because of the install 
fix that I've just pushed. And you're right, urwid SàText is tied to SàT 
releases, so they should be synchronised (Urwid SàText was formely a 
part of SàT, but it was moved in a separate library to allow other 
projects to use it).

I haven't commited the removal of Libervia section because that's how we 
work: Libervia is linked to SàT and is released at the same time with 
the same version number (except minor updates), it's outside the main 
package because it's a big project by itself, and it had some 
particularities (mainly the compilation by pyjamas). But for all files 
(README, CHANGELOGS), it's really redundant and unpractical to have them 
in both repositories, so we have a minimal bunch of legal files in 
Libervia, and we ask to use the ones of SàT core (which has to be 
installed anyway to use libervia).
This way is more handy for us (we just have to check at one place for 
INSTALL, CHANGELOG, and README files).

> README.patch fixes various typos in the README. I also took the liberty to
> precise that I'm one of the co-maintainers of the Debian package :-)

Good, commited

> Please also check out bug #51, where I put a new version of the patch to fix
> the problem of missing PYTHONPATH: https://bugs.goffi.org/show_bug.cgi?id=51

This one is not OK for me: it erase the PYTHONPATH when SàT is launched 
from the repository (i.e. without installation), and force it when SàT 
is installed.

This is bad because PYTHONPATH is dependant of the way we want to launch 
SàT, for example I have two scripts: sat and sat_dev which launch SàT 
with different PYTHONPATH (the one for my main instance, and the one for 
the dev version, as explained here: 
http://wiki.goffi.org/wiki/Howto_launch_several_S%C3%A0T_instances); 
with you patch the scripts would not work anymore.

As I'm not sure of the issue that you have, can you attach a complete 
backtrace to the bug report ? It's also better to continue the 
discussion there because else it will be difficult to track bug history.


> Oh and before I forget, we maintain manual pages in Debian since it is
> required by the Policy. I think this was discussed before and that you did
> *not* want to include them upstream for some reason, but if this has changed
> or if I'm mistaken, feel free to grab the updated version of the files
> (sat.1, jp.1, primitivus.1 and wix.1) on our VCS and to ship them with SàT
> 0.5.1:
>    http://anonscm.debian.org/cgit/collab-maint/salutatoi.git/tree/debian

We do want include them mainstream ! If I remember correctly, our 
discussion was about the commands in jp, and the fact that I want to 
make an automatic tool to generate the manpage. But as we are too busy 
for that right now, we are happy to include your manpages. I'll do that 
soon.

> P.S.: the Debian package for 0.5.0 should be ready soon, everything works now.
> I'm just waiting for a review from my dear co-maintainer (wink wink Thomas);
> if you guys are faster than he is, we may upload 0.5.1 directly.

Great :). We wait a bit for 0.5.1 as we have already found several 
issues, it would be better to wait a couple of days to be sure thing are 
stable.

Thanks again for your help/contributions/support.

Goffi