[SàT dev][en] A bunch of (minor) patches

[Matteo Cypriani]

On Mon, 15 Sep 2014 14:51:37 +0200, Goffi <goffi at goffi.org> wrote:
> For all patches I have adapted the commit message to our policy (see 
> http://wiki.goffi.org/wiki/Howto_contribute/en ).

Sorry, I didn't really pay attention to the comments.


> > 0003-Lower-default-setuptools-version.patch, as its name indicates, lowers
> > the default version of setuptools from 5.7 to 5.5 in ez_setup.py, which
> > allows to build on systems where an older version is available. It works
> > perfectly here with Debian's setuptools which is still 5.5.
> 
> commited, we should probably do the same for urwid SàText then.

Yes, I forgot to mention that this patch applied for both.


> I haven't commited the removal of Libervia section because that's how we 
> work: […]

Got it, that makes sense.


> > Please also check out bug #51, where I put a new version of the patch to
> > fix the problem of missing PYTHONPATH:
> > https://bugs.goffi.org/show_bug.cgi?id=51
> 
> This one is not OK for me: it erase the PYTHONPATH when SàT is launched 
> from the repository (i.e. without installation), and force it when SàT 
> is installed.

Indeed, PYTHONPATH="" is not ideal, I figured it was OK because it wasn't used
at all, but I guess this might not be always the case. What about
PYTHONPATH="$PYTHONPATH" ?


> This is bad because PYTHONPATH is dependant of the way we want to launch 
> SàT, for example I have two scripts: sat and sat_dev which launch SàT 
> with different PYTHONPATH (the one for my main instance, and the one for 
> the dev version, as explained here: 
> http://wiki.goffi.org/wiki/Howto_launch_several_S%C3%A0T_instances); 
> with you patch the scripts would not work anymore.
> 
> As I'm not sure of the issue that you have, can you attach a complete 
> backtrace to the bug report ? It's also better to continue the 
> discussion there because else it will be difficult to track bug history.

I'll do that. But basically the issue is that we install everything
in /usr/share/salutatoi, so without setting PYTHONPATH, the piece of python
in sat.sh fails to import SàT modules (and then I think twistd can't find the
SàT plugin).


> > Oh and before I forget, we maintain manual pages in Debian since it is
> > required by the Policy. I think this was discussed before and that you did
> > *not* want to include them upstream for some reason, but if this has
> > changed or if I'm mistaken, feel free to grab the updated version of the
> > files (sat.1, jp.1, primitivus.1 and wix.1) on our VCS and to ship them
> > with SàT 0.5.1:
> >    http://anonscm.debian.org/cgit/collab-maint/salutatoi.git/tree/debian
> 
> We do want include them mainstream ! If I remember correctly, our 
> discussion was about the commands in jp, and the fact that I want to 
> make an automatic tool to generate the manpage. But as we are too busy 
> for that right now, we are happy to include your manpages. I'll do that 
> soon.

Great!


> > P.S.: the Debian package for 0.5.0 should be ready soon, everything works
> > now. I'm just waiting for a review from my dear co-maintainer (wink wink
> > Thomas); if you guys are faster than he is, we may upload 0.5.1 directly.
> 
> Great :). We wait a bit for 0.5.1 as we have already found several 
> issues, it would be better to wait a couple of days to be sure thing are 
> stable.

I uploaded 0.5.0 yesterday, it was an emergency because of the transition to
wxPython 3.0 (otherwise SàT was going to be removed from testing in a few
days).


> Thanks again for your help/contributions/support.

You are very welcome.
-------------- section suivante --------------
Une pièce jointe autre que texte a été nettoyée...
Nom: non disponible
Type: application/pgp-signature
Taille: 819 octets
Desc: non disponible
URL: <http://lists.goffi.org/pipermail/dev/attachments/20140915/f0258c27/attachment.pgp>